Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Swap in new 1.8 RT members in OWNERS #10473

Merged
merged 1 commit into from
Apr 30, 2024
Merged

🌱 Swap in new 1.8 RT members in OWNERS #10473

merged 1 commit into from
Apr 30, 2024

Conversation

adilGhaffarDev
Copy link
Contributor

@adilGhaffarDev adilGhaffarDev commented Apr 22, 2024 •
edited by sbueringer
Loading

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #10472

/area release

@k8s-ci-robot k8s-ci-robot added area/release Issues or PRs related to releasing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 22, 2024
@adilGhaffarDev
Copy link
Contributor Author

/hold waiting for some members github handles.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 22, 2024
@sbueringer
Copy link
Member

/approve

(So you don't have to wait for an approval once the PR is finalized & someone else verified it)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 22, 2024
@adilGhaffarDev adilGhaffarDev mentioned this pull request Apr 23, 2024
Closed
37 tasks
@adilGhaffarDev
Copy link
Contributor Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 23, 2024
@adilGhaffarDev
Swap in new 1.8 RT members in OWNERS
59e21ce 
Signed-off-by: adil ghaffar <muhammad.adil.ghaffar@est.tech>
@adilGhaffarDev
Copy link
Contributor Author

@Sunnatillo @chandankumar4 please check your teams. @chrischdi @fabriziopandini please give lgtm.

@chrischdi
Copy link
Member

/lgtm

/hold

To give @Sunnatillo @chandankumar4 a chance to check.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 26, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 26, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 33bb557f8234936baf1fb4dafbe83c9fc97ce14e

chandankumar4
chandankumar4 approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@chandankumar4 chandankumar4 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@fabriziopandini
Copy link
Member

/lgtm

@Sunnatillo
Copy link
Contributor

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 30, 2024
@sbueringer
Copy link
Member

sbueringer commented Apr 30, 2024 •
edited
Loading

Tide weirdly stuck. Trying to fix it by addding an empty line to the PR description

@k8s-ci-robot k8s-ci-robot merged commit 985a01f into kubernetes-sigs:main Apr 30, 2024
21 of 22 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.8 milestone Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chandankumar4 chandankumar4 chandankumar4 approved these changes

@sbueringer sbueringer Awaiting requested review from sbueringer

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

Assignees

@chrischdi chrischdi

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release Issues or PRs related to releasing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.
7 participants
@adilGhaffarDev @sbueringer @k8s-ci-robot @chrischdi @fabriziopandini @Sunnatillo @chandankumar4